Draft
Conversation
m-kharbat
suggested changes
Aug 27, 2018
Contributor
m-kharbat
left a comment
m-kharbat
left a comment
There was a problem hiding this comment.
please add changes.txt entry
app/conf/plugins.json
Outdated
| } | ||
| } | ||
| }, { | ||
| "name": "testing", |
Contributor
There was a problem hiding this comment.
This testing section doesn't seem used, please remove it
app/plugins/tutorial/calculator.js
Outdated
| // time is measured in hours | ||
|
|
||
| angular.module('calculator', ['sql', 'translation']).controller('CalculatorController', function($scope, SQLQuery, queryResultToObjects) { | ||
| $scope.diskLoadFactor = 0.85; |
Contributor
There was a problem hiding this comment.
only attach the variables that are needed in the HTML view to the $scope. Otherwise it causes poor performance
| $scope.selectTable = "none"; | ||
| $scope.selected = "none"; | ||
|
|
||
| $scope.selectedRAM = function (){ |
app/plugins/tutorial/calculator.js
Outdated
| var stmt = "select sum(size) from sys.shards where schema_name = '" + schemaName | ||
| + "'and table_name = '"+tableName+"' and primary=true;"; | ||
| SQLQuery.execute(stmt, {}, false, false, false, false).then(function (query) { | ||
| if ((query.rows[0])[0]==null){ |
app/plugins/tutorial/calculator.js
Outdated
| +schemaName+"' and table_name = '"+tableName+"';"; | ||
| SQLQuery.execute(stmt, {}, false, false, false, false).then(function (query) { | ||
| rep = (query.rows[0])[0]; | ||
| console.log("^^^^^^^^^^^^^^^^^ "+ $scope.replicas); |
app/plugins/tutorial/testing.html
Outdated
| @@ -0,0 +1,21 @@ | |||
| <div ng-app="testing" ng-controller="testingController"> | |||
Contributor
There was a problem hiding this comment.
please remove testing.html
app/plugins/tutorial/testing.js
Outdated
| @@ -0,0 +1,42 @@ | |||
| 'use strict'; | |||
Contributor
There was a problem hiding this comment.
please remove this file if not
added 6 commits
August 27, 2018 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sharding-calculator is finalized.
Joe told us to request someone to look over it.
So it can be thought about, if it should actually be used.