Skip to content

Tests: Fix Dask not being installed for testing on Python 3.13 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2025
Merged

Tests: Fix Dask not being installed for testing on Python 3.13 #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0309f9
Tests: Fix Dask not being installed for testing on Python 3.13
amotl Mar 30, 2025
d0891b0
Chore: Remove `setup.cfg` - flake8 has been replaced by Ruff
amotl Mar 30, 2025
b3da141
Chore: Recent Ruff says "Unknown rule selector: `W504`"
amotl Mar 30, 2025
dc07396
Chore: Format `pyproject.toml` using recent `pyproject-fmt`
amotl Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ dynamic = [
dependencies = [
"backports.zoneinfo<1; python_version<'3.9'",
"crate>=2,<3",
"geojson<4,>=2.5",
"geojson>=2.5,<4",
"importlib-metadata; python_version<'3.8'",
"importlib-resources; python_version<'3.9'",
"sqlalchemy<2.1,>=1",
"sqlalchemy>=1,<2.1",
"verlib2<0.4",
]
optional-dependencies.all = [
Expand All @@ -109,7 +109,7 @@ optional-dependencies.release = [
]
optional-dependencies.test = [
"cratedb-toolkit[testing]",
"dask[dataframe]; python_version<'3.13'",
"dask[dataframe]",
"pandas<2.3",
"pueblo>=0.0.7",
"pytest<9",
Expand Down
2 changes: 0 additions & 2 deletions setup.cfg
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions src/sqlalchemy_cratedb/compat/core14.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,11 +317,7 @@ def _get_crud_params(compiler, stmt, compile_state, **kw):
_column_as_key,
kw,
)
elif (
not values
and compiler.for_executemany # noqa: W503
and compiler.dialect.supports_default_metavalue # noqa: W503
):
elif not values and compiler.for_executemany and compiler.dialect.supports_default_metavalue:
# convert an "INSERT DEFAULT VALUES"
# into INSERT (firstcol) VALUES (DEFAULT) which can be turned
# into an in-place multi values. This supports
Expand Down