Handle error before handling session in Middleware.RequireAccount #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m.RequireAccount checks if session is nil and only handles error when it is. This is not idiomatic. Also, ErrNoSession is handled with direct equality comparison. So, handle errors and protect against nil Session before adding it to the request context. And when checking for ErrNoSession, do so with errors.Is. This way, custom implementations of SessionProvider can wrap ErrNoSession, if they so choose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m.RequireAccountchecks if session is nil and only handles error when it is. When using custom implementations ofSessionProvider, it is possible that the provider returns a non-nilSessionwhen an error occurred. This pr handles the error and checks for nilSessionbefore passing the session to the context. Also, checking forErrNoSessionis done with the standard library'serrors.Is(added to the standard library in Go 1.13). This way, custom implementations of theSessionProviderinterface can wrap the error if they need to provide additional context down the line.