Skip to content

Destroy the Network graph on component unload #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Destroy the Network graph on component unload #132

wants to merge 1 commit into from

Conversation

daliborfilus
Copy link

fixes #131

@daliborfilus
Copy link
Author

I can confirm that by adding this, the graph re-renders again and again successfully without performance loss.

@Sothatsit
Copy link

+1, this is great

ObaidAshiq
ObaidAshiq reviewed Jun 20, 2024
View reviewed changes
Copy link

@ObaidAshiq ObaidAshiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like for above 300 nodes its a problem, but for smaller amount of nodes, it isn't
But its good to have this feature for certain case
Really liked it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ObaidAshiq ObaidAshiq ObaidAshiq left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Graph not unloading?

3 participants

@daliborfilus @Sothatsit @ObaidAshiq