Skip to content

Conversation

@ledigang
Copy link

@ledigang ledigang commented Nov 21, 2025

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

minor improvement for docs

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@ledigang ledigang requested a review from a team as a code owner November 21, 2025 08:26
@ledigang ledigang requested review from XinyuCRO and randy-cro and removed request for a team November 21, 2025 08:26
@ledigang
Copy link
Author

@thomas-nguy Hi, Could you please review this PR at your convenience? Thank you very much.

@thomas-nguy thomas-nguy enabled auto-merge December 2, 2025 07:06
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.85%. Comparing base (606d520) to head (4c570ad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
- Coverage   33.50%   30.85%   -2.66%     
==========================================
  Files         105      113       +8     
  Lines       15728    15989     +261     
==========================================
- Hits         5270     4933     -337     
- Misses       9415    10187     +772     
+ Partials     1043      869     -174     
Flag Coverage Δ
integration_tests ?
integration_tests_byzantine 11.52% <ø> (ø)
integration_tests_gov 11.76% <ø> (ø)
integration_tests_grpc 11.76% <ø> (ø)
integration_tests_ibc 26.76% <ø> (ø)
integration_tests_ledger 11.74% <ø> (ø)
integration_tests_slow 11.74% <ø> (ø)
integration_tests_solomachine 11.55% <ø> (ø)
integration_tests_upgrade 11.76% <ø> (ø)
unit_tests 13.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants