Refactor solc-select #243
Draft
Refactor solc-select #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elopez
commented
Sep 16, 2025
elopez
commented
- Improved handling of execute permissions on binaries
- Improved exception handling
- Refactor into separate components
- Added type checks with mypy
- Connection pool sharing
- Parallel downloads
Binaries should be non-executable when we write them, and then chmodded +x once we verify their hashes match.
elopez
force-pushed
the
mypy
branch
3 times, most recently
from
4ef1e2c to
d936a4e
Compare
elopez
force-pushed
the
mypy
branch
3 times, most recently
from
3c25971 to
d2ed868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.