fix: sync discovery schema/spec with IETF-RFC.md #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Appendix D Provider diagram tokens/fields to match the draft (tokenEndPoint, http-sig, http-request-signatures, publicKeys[]) - Align spec.yaml wording/examples with the draft (capability tokens, accessTypes, tokenEndPoint URL vs inviteAcceptDialog path) - Move discovery schema to schemas/ocm-discovery.jsonc with draft-strict URL rules Signed-off-by: Mahdi Baghbani <[email protected]>
Signed-off-by: Mahdi Baghbani <[email protected]>
Signed-off-by: Mahdi Baghbani <[email protected]>
glpatcern
requested changes
Jan 5, 2026
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
Thanks Mahdi (and happy new year!). I have a comment on the comments ;)
| @@ -0,0 +1,88 @@ | |||
| { | |||
| // Discovery schema for OCM API Discovery (JSON Schema, JSONC for comments). | |||
Member
There was a problem hiding this comment.
Do we really need to add comments here? This is possibly to be brought to the WG chairs, also to understand how to evolve the spec and keep things aligned between the I-D, the OpenAPI file and the JSON schemas here.
Maybe I'd take this change out of the PR as the rest is pretty much good to go, and then we discuss this on its own.
| | - shareTypes[] | | - exchange-token | | | ||
| | - protocols{} | | - http-sig | | | ||
| +------------------+ | - invites | | | ||
| | | - notifications | | |
Member
There was a problem hiding this comment.
Happy to see this diagram updated :) the concern is whether to put some ... and refer to the single source of truth in the same document, to avoid this part to drift?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I was late to read the previous PR and missed some details, here are my fixes:
Draft consistency fixes (
IETF-RFC.md)tokenEndPoint,http-sig,http-request-signatures).OpenAPI alignment (
spec.yaml)accessTypesplural, andtokenEndPointwording + examples).inviteAcceptDialogis a path,tokenEndPointis an absolute URL.Discovery JSON Schema becomes JSONC and follows the draft strictly (
schemas/ocm-discovery.jsonc)inviteAcceptDialogmust start with/,tokenEndPointmust behttp(s)://....publicKey(deprecated) and RFC 9421publicKeys[].