>> Updated all diag_step functions. Removed all csm[0] and csm[1] add…#10
Open
lvlanson wants to merge 1 commit intoctralie:masterfrom
Open
>> Updated all diag_step functions. Removed all csm[0] and csm[1] add…#10lvlanson wants to merge 1 commit intoctralie:masterfrom
lvlanson wants to merge 1 commit intoctralie:masterfrom
Conversation
…itions to diag,left,up. Instead adding csm[2] to allover score \n>> In dtw.py updated addition of diag_left + diag_right - csm according to formula in paper, removing -1 from diag arrays and corresponding csm array. Adding shift parameter, if -1 was in first place of array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed all the additions to the directions (up, diag, left) and instead added to the score the cost of the field.
In dtw.py for the diag arrays I removed the -1 entry and the corresponding costmatrix entry. Then I added according to the formula presented in the paper. Additionally I added a parameter
shiftsuch that it shifts the index if a-1was removed in the first spot of a diagonal.