-
Notifications
You must be signed in to change notification settings - Fork 10
[WIP] - Create an Execution Environment Builder #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cigamit
wants to merge
12
commits into
main
Choose a base branch
from
eebuilder
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a66d892
EE Builder initial
cigamit 98eb5b0
Update build_ee script
cigamit d2c12f6
Fix migrations
cigamit 9a36be7
Apply some fixes, start working on permissions
cigamit 96b8636
More fixes and add python tests
cigamit 5378ca2
Add option to allow changing of container security flags
cigamit 321255f
More fixes
cigamit 6635305
More fixes
cigamit 23f18ef
Add UI tests
cigamit 86f1b3d
Minor fixes
cigamit 5900a79
Move migration
cigamit 89eeffb
Add more unit tests
cigamit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Copyright (c) 2023 Ctrl IQ, Inc. | ||
| # All Rights Reserved. | ||
|
|
||
| from django.urls import path | ||
|
|
||
| from awx.api.views import ( | ||
| ExecutionEnvironmentBuilderList, | ||
| ExecutionEnvironmentBuilderDetail, | ||
| ExecutionEnvironmentBuilderAccessList, | ||
| ExecutionEnvironmentBuilderObjectRolesList, | ||
| ExecutionEnvironmentBuilderCopy, | ||
| ExecutionEnvironmentBuilderLaunch, | ||
| ) | ||
|
|
||
|
|
||
| urls = [ | ||
| path('', ExecutionEnvironmentBuilderList.as_view(), name='execution_environment_builder_list'), | ||
| path('<int:pk>/', ExecutionEnvironmentBuilderDetail.as_view(), name='execution_environment_builder_detail'), | ||
| path('<int:pk>/copy/', ExecutionEnvironmentBuilderCopy.as_view(), name='execution_environment_builder_copy'), | ||
| path('<int:pk>/launch/', ExecutionEnvironmentBuilderLaunch.as_view(), name='execution_environment_builder_launch'), | ||
| path('<int:pk>/access_list/', ExecutionEnvironmentBuilderAccessList.as_view(), name='execution_environment_builder_access_list'), | ||
| path('<int:pk>/object_roles/', ExecutionEnvironmentBuilderObjectRolesList.as_view(), name='execution_environment_builder_object_roles_list'), | ||
| ] | ||
|
|
||
| __all__ = ['urls'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Copyright (c) 2024 Ansible, Inc. | ||
| # All Rights Reserved. | ||
|
|
||
| from django.urls import path | ||
|
|
||
| from awx.api.views import ( | ||
| ExecutionEnvironmentBuilderBuildList, | ||
| ExecutionEnvironmentBuilderBuildDetail, | ||
| ExecutionEnvironmentBuilderBuildCancel, | ||
| ExecutionEnvironmentBuilderBuildRelaunch, | ||
| ExecutionEnvironmentBuilderBuildStdout, | ||
| ExecutionEnvironmentBuilderBuildEventsList, | ||
| ) | ||
|
|
||
|
|
||
| urls = [ | ||
| path('', ExecutionEnvironmentBuilderBuildList.as_view(), name='execution_environment_builder_build_list'), | ||
| path('<int:pk>/', ExecutionEnvironmentBuilderBuildDetail.as_view(), name='execution_environment_builder_build_detail'), | ||
| path('<int:pk>/cancel/', ExecutionEnvironmentBuilderBuildCancel.as_view(), name='execution_environment_builder_build_cancel'), | ||
| path('<int:pk>/relaunch/', ExecutionEnvironmentBuilderBuildRelaunch.as_view(), name='execution_environment_builder_build_relaunch'), | ||
| path('<int:pk>/stdout/', ExecutionEnvironmentBuilderBuildStdout.as_view(), name='execution_environment_builder_build_stdout'), | ||
| path('<int:pk>/events/', ExecutionEnvironmentBuilderBuildEventsList.as_view(), name='execution_environment_builder_build_events_list'), | ||
| ] | ||
|
|
||
| __all__ = ['urls'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExecutionEnvironmentBuilderBuild responses won't include a
related.stdoutURL (UnifiedJobSerializer only adds it for Job/ProjectUpdate/InventoryUpdate/AdHocCommand). The UI OutputToolbar only renders the “Download Output” button whenjob.related.stdoutis present, so EE builder builds will lack the download action. Consider overridingget_related()in ExecutionEnvironmentBuilderBuildSerializer (or extending UnifiedJobSerializer.get_related) to add theexecution_environment_builder_build_stdoutlink.