Skip to content

Conversation

@jsbroks
Copy link
Member

@jsbroks jsbroks commented Apr 19, 2025

Reverts #11

Summary by CodeRabbit

  • Chores
    • Removed the option to configure the "enable_new_policy_engine" setting from the deployment configuration. This setting is no longer available for customization.

@coderabbitai
Copy link

coderabbitai bot commented Apr 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change removes the enable_new_policy_engine variable from the Terraform configuration. The variable is deleted from the root variables.tf, the helm_release module's variables.tf, and all references to it are eliminated from main.tf files at both the root and module levels. The configuration and logic no longer support or pass this variable, effectively deprecating its use throughout the codebase.

Changes

File(s) Change Summary
variables.tf, modules/helm_release/variables.tf Removed the enable_new_policy_engine variable declaration (type: bool, default: false).
main.tf Removed the enable_new_policy_engine input from the helm_release module block.
modules/helm_release/main.tf Removed the enableNewPolicyEngine setting from the Helm release configuration's global map.

Possibly related PRs

Poem

A toggle is gone, no more to be seen,
The policy engine’s switch—now wiped clean.
No more bool to pass, no flag to define,
Our Terraform scripts are looking just fine!
With variables trimmed and modules made neat,
This bunny hops forward—change is a treat! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 135551a and afba76b.

📒 Files selected for processing (4)
  • main.tf (0 hunks)
  • modules/helm_release/main.tf (0 hunks)
  • modules/helm_release/variables.tf (0 hunks)
  • variables.tf (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jsbroks jsbroks merged commit 1c279bb into main Apr 19, 2025
1 of 3 checks passed
@jsbroks jsbroks deleted the revert-11-policy-engine-flag branch April 19, 2025 02:22
adityachoudhari26 pushed a commit that referenced this pull request Apr 19, 2025
## [1.9.0](v1.8.0...v1.9.0) (2025-04-19)

### Features

* Revert policy engine feature flag ([#12](#12)) ([1c279bb](1c279bb))
@adityachoudhari26
Copy link
Contributor

This PR is included in version 1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants