Skip to content

Conversation

waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@waralexrom waralexrom requested a review from a team as a code owner October 15, 2025 16:09
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 15, 2025
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.77%. Comparing base (f556b62) to head (7e7b15c).
⚠️ Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f556b62) and HEAD (7e7b15c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f556b62) HEAD (7e7b15c)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10060       +/-   ##
===========================================
- Coverage   77.13%   48.77%   -28.37%     
===========================================
  Files         440      196      -244     
  Lines       89307    15824    -73483     
  Branches     3101     3101               
===========================================
- Hits        68889     7718    -61171     
+ Misses      20029     7717    -12312     
  Partials      389      389               
Flag Coverage Δ
cube-backend 48.77% <100.00%> (+<0.01%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM! Left a minor neatpick

Comment on lines 13 to 15
const prepared = prepareYamlCompiler(modelContent);
const { metaTransformer } = prepared;
const { compiler } = prepared;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const prepared = prepareYamlCompiler(modelContent);
const { metaTransformer } = prepared;
const { compiler } = prepared;
const { metaTransformer, compiler } = prepareYamlCompiler(modelContent);

@waralexrom waralexrom merged commit b45a1c4 into master Oct 16, 2025
310 of 325 checks passed
@waralexrom waralexrom deleted the meta-for-switch-dimension branch October 16, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants