-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(cube): Meta type for switch dimension #10060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #10060 +/- ##
===========================================
- Coverage 77.13% 48.77% -28.37%
===========================================
Files 440 196 -244
Lines 89307 15824 -73483
Branches 3101 3101
===========================================
- Hits 68889 7718 -61171
+ Misses 20029 7717 -12312
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM! Left a minor neatpick
const prepared = prepareYamlCompiler(modelContent); | ||
const { metaTransformer } = prepared; | ||
const { compiler } = prepared; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const prepared = prepareYamlCompiler(modelContent); | |
const { metaTransformer } = prepared; | |
const { compiler } = prepared; | |
const { metaTransformer, compiler } = prepareYamlCompiler(modelContent); |
Check List