Don't flip direction to zero when mouse/touch is stationary.#18
Open
simonratner wants to merge 2 commits intocubiq:masterfrom
Open
Don't flip direction to zero when mouse/touch is stationary.#18simonratner wants to merge 2 commits intocubiq:masterfrom
simonratner wants to merge 2 commits intocubiq:masterfrom
Conversation
Mousemove/touchmove events keep on firing (once a second or so) even if the position is not changing. This resulted in the direction being reset to zero if one holds the mouse/finger stationary for a while, resulting in incorrect behaviour once the mouse/finger is released.
Contributor
Author
|
Sorry, this isn't a complete fix. I'll send a proper fix in a bit. |
Owner
|
would you integrate this into the latest version so your name appears between the collaborators? Thanks and sorry for not merging this earlier... I really haven't seen this pull request before, sorry again! |
|
Doesn't look like f1e1904 ever got merged. |
|
@cubic Here's the patch by @simonratner applied to the latest repo: #39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mousemove/touchmove events keep on firing (once per second or so) even if the pointer position is not changing. This resulted in the direction being reset to zero if one holds the mouse/finger stationary for a while. Since __checkPosition only has a two-way branch, a zero direction always fell into the second branch, resulting in sporadic broken behaviour for backwards (right, positive direction) swipes while forward (left, negative direction) swipes worked perfectly.
Specifically:
This is the minimal fix, it would probably make sense to also add a branch in __checkPosition to do the right thing when directionX == 0, since that could still happen when snapThreshold == 0.