Fix for #29; instant snap back when looping: false#70
Open
dokterbob wants to merge 1 commit intocubiq:masterfrom
Open
Fix for #29; instant snap back when looping: false#70dokterbob wants to merge 1 commit intocubiq:masterfrom
dokterbob wants to merge 1 commit intocubiq:masterfrom
Conversation
|
Hey! Great to see some work on this. Unfortunately I haven't used this library in over a year and I'm not sure my comments would be terribly helpful. I think I remember what the problem was and your fix is probably more readable than the one I suggested at the time (which required an understanding of the code structure). Basically, I haven't tried it, but it doesn't look bad :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the suggestions in #29, I have removed
dist = 0around line 373 which seems to have been used in theifstatement later on. Instead, I have assigned the condition to a variable and have OR'ed that with the original condition.This seems to work for me but I would love additional feedback from the original participants in the issue report (@ghost, @MathieuLoutre and @linlex).