Skip to content

Commit 4cc3194

Browse files
committed
curl: re-enable UNICODE by default
The article https://blog.orange.tw/posts/2025-01-worstfit-unveiling-hidden-transformers-in-windows-ansi/ may tip the balance towards UNICODE enabled being the less bad solution. It mitigates Windows's own shortcomings in translating between Unicode and 8-bit codepages (aptly coined "WorstFit"). It may also be a way to receive more feedback on curl UNICODE mode issues, also possibly giving a new momentum to address them. Original reasons for disabling, written in bb02905 still apply today. Also add a `nounicode` config option to build without UNICODE. Follow-up to bb02905
1 parent d887d63 commit 4cc3194

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ SSL | ✓ | ✓ | ✓ | ✓ | ✓ | ✓
103103
SSPI | ✓ | - | - | ✓¹ | ✓¹ | ✓¹ | ✓¹ | |
104104
SSLS-EXPORT | ✓ | ✓ | ✓ | ✓ | | | | |
105105
threadsafe | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
106-
Unicode | | - | - | | | | | |
106+
Unicode | | - | - | ✓¹ | ✓¹ | ✓¹ | ✓¹ | ✓¹ |
107107
UnixSockets | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | |
108108
zstd | ✓ | ✓ | ✓ | ✓ | | | | |
109109

_build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ set -o xtrace -o errexit -o nounset; [ -n "${BASH:-}${ZSH_NAME:-}" ] && set -o p
7878
# curldocs include curl Markdown manual pages in the package
7979
# msvcrt build against msvcrt instead of UCRT (for win target)
8080
# gcc build with GCC (including Apple clang aliased to gcc) (defaults to llvm, and "gcc" (= Apple clang) for mac target)
81-
# unicode build curl in UNICODE mode (for win target) [EXPERIMENTAL]
81+
# nounicode build curl without [EXPERIMENTAL] UNICODE mode (for win target)
8282
# osnoidn build curl without OS-supplied IDN support
8383
# werror turn compiler warnings into errors
8484
# nodumpconf do not dump curl_config.h

curl.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ _VER="$1"
4444
# [ "${_CC}" = 'gcc' ] && LDFLAGS+=' -Wl,--trace'
4545
fi
4646

47-
if [ "${_OS}" = 'win' ] && [[ "${_CONFIG}" = *'unicode'* ]]; then
47+
if [ "${_OS}" = 'win' ] && [[ "${_CONFIG}" != *'nounicode'* ]]; then
4848
options+=' -DENABLE_UNICODE=ON'
4949
fi
5050

0 commit comments

Comments
 (0)