[-] return the error from MultiWriter.DefineMetrics(), fixes #1222#1224
Merged
pashagolub merged 2 commits intocybertec-postgresql:masterfrom Feb 24, 2026
Merged
Conversation
pashagolub
changed the title
MultiWriter.DefineMetrics(), fixes #1222
Mahmoud-Ayman-Saleh
force-pushed
the
fix-bugs
branch
from
ed2e000 to
8ddc44f
Compare
Mazen050
reviewed
Feb 23, 2026
Makeepan-dev
pushed a commit
to Makeepan-dev/pgwatch
that referenced
this pull request
Feb 25, 2026
…ec-postgresql#1222 (cybertec-postgresql#1224) * Fix: return the accumulated error instead of nil cybertec-postgresql#1222 * improve tests --------- Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: return the accumulated error instead of nil
Add TestDefineMetrics to cover the failure scenarios: