Skip to content

[+] add tests for Reaper.FetchMetric()#1268

Merged
pashagolub merged 4 commits intomasterfrom
add-tests-for-reaper-fetchmetric
Mar 2, 2026
Merged

[+] add tests for Reaper.FetchMetric()#1268
pashagolub merged 4 commits intomasterfrom
add-tests-for-reaper-fetchmetric

Conversation

@pashagolub
Copy link
Collaborator

@pashagolub pashagolub commented Mar 2, 2026

Description

part of #1099

@pashagolub pashagolub self-assigned this Mar 2, 2026
@pashagolub pashagolub added the test New test case or request label Mar 2, 2026
@coveralls
Copy link

coveralls commented Mar 2, 2026

Pull Request Test Coverage Report for Build 22578745718

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.7%) to 80.612%

Files with Coverage Reduction New Missed Lines %
internal/sinks/prometheus.go 2 75.85%
Totals Coverage Status
Change from base Build 22573264309: 1.7%
Covered Lines: 4449
Relevant Lines: 5519

💛 - Coveralls

@pashagolub pashagolub merged commit 2797305 into master Mar 2, 2026
4 checks passed
@pashagolub pashagolub deleted the add-tests-for-reaper-fetchmetric branch March 2, 2026 13:46
@Mazen050
Copy link
Contributor

Mazen050 commented Mar 2, 2026

@pashagolub should I make PRs for the rest of the tests in #1223 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test New test case or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants