Reactor commodity preference change timestep comparison update#535
Open
opotowsky wants to merge 3 commits intocyclus:mainfrom
Open
Reactor commodity preference change timestep comparison update#535opotowsky wants to merge 3 commits intocyclus:mainfrom
opotowsky wants to merge 3 commits intocyclus:mainfrom
Conversation
…after the change also get the new pref change scheme
…sting the ability for the fuel pref change to be seen by a reactor that enters after the fuel time with an input file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one-character update allows reactors that are deployed after the timestep of the preference change to "see" the new preference change. Previously, newly deployed reactors defaulted back to the original commodity preference scheme.
There is an added unit test for the basic function as well as an integration/regression test to show that a reactor deployed after the preference change time will keep the latest preference.
P.S. This is also an issue with the recipe change functionality but that is not included in this PR; see Issue #534