Skip to content

Conversation

@dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented Jul 18, 2025

closes #6567, closes #6860, closes #6859

Tasks batched (for DB read) during a graph walk, and processed at the end of that walk.

Window resizes typically include many walks (for each active task), so the DB will have that many calls.
However, no state-less tasks will exist.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
Copy link
Member

oliver-sanders commented Nov 13, 2025

This seems like the right sort of fix (i.e, get the task status right first time).

If I'm reading this correctly:

  • Before we were performing all the DB lookups at once.
  • This change splits it up into smaller batches.

If I'm understanding correctly, the root cause is that the data store is trying to push out incomplete deltas before it has actually gathered all of the required information. This (only?) happens on reload.

If so, could we not just delay sending the deltas (after reload) until they are complete (i.e, after we have finished the first walk)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

data store: blank task state

2 participants