Don't infer optionality from RHS implicit outputs. #6999
Conversation
hjoliver
force-pushed
the
relax-optionality-constraints
branch
from
28d541e to
80ca9c9
Compare
hjoliver
force-pushed
the
relax-optionality-constraints
branch
7 times, most recently
from
5086645 to
025515d
Compare
| if name in self.family_map: | ||
| raise GraphParseError( | ||
| f"Family trigger required: {left} => {right}" | ||
| ) |
There was a problem hiding this comment.
Bug in master: the code here was adding :succeeded to bare family names on the left side of trigger pairs: FAM --> FAM:succeeded.
This results in failed validation later, but with a cryptic error message.
E.g. for a => FAM => c on master:
$ cylc val .
GraphParseError: Illegal family trigger in FAM:succeeded
On this branch:
$ cylc val .
GraphParseError: Family trigger required: FAM => c
| for outp in [TASK_OUTPUT_SUCCEEDED, TASK_OUTPUT_FAILED]: | ||
| self._set_output_opt( | ||
| name, outp, optional, suicide, fam_member) | ||
| return |
There was a problem hiding this comment.
Bug in master, possibly inconsequential though.
hjoliver
force-pushed
the
relax-optionality-constraints
branch
from
025515d to
f50182e
Compare
There was a problem hiding this comment.
LGTM.
Nice tests.
Ensured that it's still possible to mark an output as optional on the RHS when required.
Ran through the examples in https://cylc.github.io/cylc-doc/stable/html/user-guide/writing-workflows/scheduling.html#graph-branching and checked that the auto-generated completion expressions match before and after.
One efficiency suggestion that I'll punt to a followup PR.
4 participants
Close #6744
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.