-
Notifications
You must be signed in to change notification settings - Fork 30
add info icon with hover details to workspace toolbar #2361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Makes sense. But, adding this to the workflow status does make it rather long. Our operators seem to be keen on having lots of narrow windows side-by-side where this information would be cut off. We do intend to extend the "Info View" to also provide workflow information, including metadata and the hostname, etc - #1898 Would this satisfy your requirements? Or would opening a new view be too inconvenient? Otherwise, would you be ok with making this information available via a tooltip? E.g, we could have an information icon next to the workflow ID. Hover over it to reveal the hostname, port, etc (all the information from the workflows table). Click on it to bring up the "Info View" for the workflow (along with metadata, broadcasts, etc). WDYT? |
All of the above really, workflow info view with more information than the icon hover (maybe a lumino tab opened on clicking on the icon).. Perhaps close this on the open/merge of that PR...
To be fair, some server/user combinations can be very long... (although most workflow status messages are just |
|
I hadn't twigged (or more likely had forgotten) that we already do this with the Cylc version. That should really get lumped in with this.
Ok, we can easily add the hover-over icon now, should be a simple change. Here's a starter for 10: <v-tooltip>
<template v-slot:activator="{ props }">
<v-icon icon="mdi-information-outline" v-bind="props" />
</template>
<dl>
<dt>Owner</dt>
<dd>{{ currentWorkflow.node.owner }}</dd>
<dt>Host</dt>
<dd>{ currentWorkflow.node.host }}</dd>
<dt>Cylc version</dt>
<dd>...</dd>
</dl>
</v-tooltip>Should be able to stick that next to the workflow ID in the toolbar. |
7e47674 to
23669e5
Compare
d689227 to
67ca97f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preferably this icon would be to the right of the fixed controls, so that those controls do not jump when the workflow starts/stops.
Also IMO the tooltip would be easier to read if the fields were on the same line as their title, i.e.
Owner: j.bloggs
instead of
Owner:
j.bloggs
Will try to get this into 2.11.0 but for now I've tagged it against 2.12.0
67ca97f to
4248d58
Compare
4248d58 to
7d94d7c
Compare
|
Nice, however I think it is useful to see the Cylc version at a glance in case it's an older version. So I propose using a chip with the icon and version: dwsutherland#73 WDYT? |
|
Personally, I don't think that the Cylc version should be visible in the toolbar. There's much too much information about a workflow to display in this manner, and the Cylc version isn't generally pertinent. The versions of all workflows are visible in the "Workflow Table" view. Also, we will one day provide an upgrade functionality which will be accessible via the workflows sidebar. |
Happy for it to go away into the tooltip when we reach that point. However for the time being I think it's useful for Ops here |
It is useful for Ops here (about as useful as knowing the host IMO).. If the UIS version is at hand (which it is), it could pop-up/show if different... Thoughts? |
48c38c9 to
38ca379
Compare
Co-authored-by: Ronnie Dutta <[email protected]>
acd5f28 to
8f02b5d
Compare
MetRonnie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍





While managing ESNZ/NIWA's operation, It's always bugged me that I have to go elsewhere (top of workflow log or

cylc scancommand or table view) to find out which host this workflow is running on..So I though it would be useful to have it in the toolbar of the workflow workspace view (as it is for Cylc version, which now only shows if it differs from UIS cylc-flow version):
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.