feat: add geckodriver to cypress/browsers and cypress/included #1362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
cypress/browsersandcypress/includedimages do not include the Mozilla geckodriver that is required for Firefox testing.Change
Update
FIREFOX_VERSIONto139.0.1in factory/.envAdd Mozilla geckodriver to
cypress/browsersandcypress/includedby using the build parameterGECKODRIVER_VERSIONin factory/docker-compose.yml and in factory/test-project/docker-compose.ymlAdd "Mozilla geckodriver" sub-section to Browsers
Remove unneeded separate
firefox-geckodriverbuild and test definitions. These were used in the interim situation where geckodriver was added to thecypress/factorybuild and not yet to thecypress/browsersandcypress/includedbuilds.Tests
Disconnect from network