feat: add Chrome for Testing to cypress/factory build process #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AtofStryker
reviewed
Jun 16, 2025
There was a problem hiding this comment.
Hey @MikeMcC399. I'm having some trouble running the verification steps on the chrome for testing example. It looks like none of the browsers are installed in the image? I am thinking I missed something here
|
If you're running the verification steps that I provided, then the only browser that is supposed to be installed is Here is a simplified set of steps you can try, together with logs: git clone --branch factory/cft https://github.com/MikeMcC399/cypress-docker-images
cd cypress-docker-images
cd factory
docker compose build factory
cd test-project
set -a && . ../.env && set +a
docker compose run --build --rm test-factory-chrome-for-testing |
|
@MikeMcC399 I think I know whats going on. I am on |
The fact that Chrome for Testing, like Chrome, isn't available for It does say so on https://github.com/MikeMcC399/cypress-docker-images/tree/factory/cft/examples/chrome-for-testing though and on https://github.com/MikeMcC399/cypress-docker-images/blob/factory/cft/factory/README.md#chrome_for_testing_version IIRC you only see the arm64 skip message if you use if (process.arch !== 'x64') {
console.log(`Chrome for Testing only available for x64. Not currently available for architecture: ${process.arch}`)
process.exit(0)
} |
|
I've added notes for the README and the .env file to call out the non-availability of Chrome for Testing on |
@MikeMcC399 thanks for adding this! I was able to test on my amd64 machine and things worked as expected. |
AtofStryker
approved these changes
Jun 17, 2025
|
Thanks for testing it out! I'm glad to see it merged 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
Google targets web app testing with their Chrome for Testing flavor of Chrome.
Currently the cypress/factory build process supports the installation of Google Chrome by specifying CHROME_VERSION. It does not support Chrome for Testing.
Cypress introduced support for Chrome for Testing in [email protected].
Google has restricted the use of the
--load-extensionflag in Chrome version 137 and above and continues to allow its use in Chrome for Testing. See also [email protected] changelog.The directory examples/chrome-for-testing shows how to add Chrome for Testing to a custom Cypress Docker image using shell commands in a Dockerfile. This diverges from the method used to install other browsers through
cypress/factorythat require only a single version parameter to install any of the browsers: Chrome, Edge or Firefox.Change
Add an option to install the Google Chrome for Testing browser using the cypress/factory build process.
Chrome for Testing is downloaded from
https://storage.googleapis.com/chrome-for-testing-publicas defined in Chrome for Testing > JSON API endpoints. Puppeteer is not used.The Docker ARG parameter is
CHROME_FOR_TESTING_VERSIONFactory version is bumped to
5.11.0CircleCI contains an additional test:
test-factory-chrome-for-testingVerification