fix: skip individual failed Node.js key imports #1385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
When importing Node.js release keys, if a key cannot be imported from the primary keyserver hkps://keys.openpgp.orgs and there is a network connection issue to the fallback keyserver
keyserver.ubuntu.com
, then importing ALL Node.js keys fails. This in turn causes a build failure, even if the corresponding key, that could not be imported, is not subsequently needed to verify the actual Node.js version selected withNODE_VERSION
.Environment
cypress/factory:5.11.3
cypress/factory:5.11.4
Background
As a consequence of catastrophic verification issues with the then Active LTS Node.js version
22.17.0
:cypress/included:14.5.1
Change
In factory/installScripts/node/default.sh trap any import failure and log a failure message allowing the workflow instead to continue.
The result is that a network connection issue to the fallback keyserver
keyserver.ubuntu.com
or similar issue will no longer fail the build at the stage of importing Node.js keys. Instead, the build will fail as a consequence ONLY if there is a failure to import the exact key needed to verify the selected version of Node.js through theNODE_VERSION
parameter.In factory/.env increment
FACTORY_VERSION
FACTORY_VERSION
5.11.4
5.11.5