Skip to content

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Jul 18, 2025

Situation

When importing Node.js release keys, if a key cannot be imported from the primary keyserver hkps://keys.openpgp.orgs and there is a network connection issue to the fallback keyserver keyserver.ubuntu.com, then importing ALL Node.js keys fails. This in turn causes a build failure, even if the corresponding key, that could not be imported, is not subsequently needed to verify the actual Node.js version selected with NODE_VERSION.

Environment

  • cypress/factory:5.11.3
  • cypress/factory:5.11.4

Background

As a consequence of catastrophic verification issues with the then Active LTS Node.js version 22.17.0:

Change

In factory/installScripts/node/default.sh trap any import failure and log a failure message allowing the workflow instead to continue.

The result is that a network connection issue to the fallback keyserver keyserver.ubuntu.com or similar issue will no longer fail the build at the stage of importing Node.js keys. Instead, the build will fail as a consequence ONLY if there is a failure to import the exact key needed to verify the selected version of Node.js through the NODE_VERSION parameter.

In factory/.env increment FACTORY_VERSION

Environment variable Before After
FACTORY_VERSION 5.11.4 5.11.5

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 added the bug label Jul 18, 2025
@MikeMcC399 MikeMcC399 self-assigned this Jul 18, 2025
@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 18, 2025 06:59
@jennifer-shehane jennifer-shehane merged commit 3865ad8 into cypress-io:master Jul 18, 2025
51 checks passed
@MikeMcC399 MikeMcC399 deleted the skip-node-key-import-fail branch July 18, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I have update my docker to include the lastest keyserver changes in node but get an error from keyserver.ubuntu.com

3 participants