chore: exclude npm registry from link check #1422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
Executing
npm run check:markdownresults in errors checking the ./factory/README.md document:These are HTTP 403 Forbidden errors, resulting from the npm registry refusing to honor non-browser requests.
Change
Add
^https://www.npmjs.comtoignorePatternsin markdownLinkConfig.jsonRemove the existing
"pattern": "^#S*". This is not necessary.Verification
Confirm that there are no link issues reported.
Comment
Due to a bug in markdown-link-check the return code is always set to success. Once this is fixed, the
check:markdownscript could be added to CI to report on link issues.