[WIP] Updating Paths and Path Assignment in Select Files#177
Open
gwaybio wants to merge 9 commits intocytomining:masterfrom
Open
[WIP] Updating Paths and Path Assignment in Select Files#177gwaybio wants to merge 9 commits intocytomining:masterfrom
gwaybio wants to merge 9 commits intocytomining:masterfrom
Conversation
Member
Author
|
cc @jccaicedo for review |
Member
|
This looks good to me. There is an issue with the Travis build, but it's unrelated to the changes in this PR, so we are good to go. |
Member
|
Actually, the errors are due to the changes in this PR. Can you run Several tests break because of these updates. Also, make sure you pull the latest version, cause we fixed some tests recently. |
Member
Author
|
Thanks @jccaicedo - working through this now. I am finding errors that indeed are breaking the tests! Running through travis I did get an error. Documenting here: |
870f8ad to
0a4fdfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two related changes introduced into a subset of the
deepprofilercode base.rootpath assignment__main__.py,boxes.py, andmodel.pyos.path.join__main__.py,boxes.py,image_dataset.pyandmodel.pyI did not look into updating other scripts that were not touched by the following command:
python deepprofiler \ --root=/Users/gway/repos/dp-test \ --config=/Users/gway/repos/dp-test/inputs/config/config.json \ trainNote that I am running the above command in the
DeepProfilerrepository directory.