Skip to content

History refurbish #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 87 commits into
base: main
Choose a base branch
from
Open

History refurbish #22

wants to merge 87 commits into from

Conversation

jorbakk
Copy link

@jorbakk jorbakk commented Mar 30, 2023

New backend for handling a large number of history entries along with a different user interface for handling the history:

  • practically unlimited number of history entries with fast access thanks to an sqlite backend
  • history hints are shown while typing input or navigating history (similar to fish shell)
  • input can be seamlessly extended with the history hint using the usual keys for cursor movement
  • history hints are continuously updated using a prefix based search through history while typing

The sqlite backend adds a dependency and could be replaced by e.g. a memory mapped file in the long run. However, currently it's easier to explore more advanced features with the sqlite backend. Advanced features could be:

  • handle parallel sessions (e.g. based on terminal name) and merge history when exiting a session
  • prioritize commands issued in the current working directory
  • add a directory history
  • ...

jorbakk added 30 commits March 18, 2023 18:43
@jorbakk
Basic function to open/close an db and prepare statements
4a615e6
@jorbakk
Added db functions to exec prepared statments
37b6f17
@jorbakk
Push commands to the cmd table
d64a138
@jorbakk
Implemented history_get()
6c9b09d
@jorbakk
Fixed command index range in history_get()
fb5beff
@jorbakk
First attempt of search implementation
0fca4bb
@jorbakk
Commented out some original code
e4a6723
@jorbakk
Commented out pushing empty line in main edit loop edit_line()
b947871
@jorbakk
Browse (and search) history with current input as prefix, show result…
e635d25 
… as a hint
@jorbakk
Commented out some more code in history_load_from()
23629ec
@jorbakk
Honor duplicate entry option
6e80116
@jorbakk
Show first history match in hint on typing characters at prompt
dc25760
@jorbakk
Move word from latest history hint to input on KEY_RIGHT
0534f60
@jorbakk
Fixed not showing most recent entry with up key
3eb2712
@jorbakk
Deactivated some code
a18937c
@jorbakk
Deactivated explicit history search commands (ctl-r/s)
038628b
@jorbakk
Example program opens history.db with sqlite backend, otherwise histo…
1f24bef 
…ry.txt
@jorbakk
Some code cleanup
1311bde
@jorbakk
Free history entry at callsite
f5c2a50
@jorbakk
Disabled completion hinting, mess a little with hint replacement
acf495f
@jorbakk
Some cleanup
8af98c4
@jorbakk
Removed double replacement of hint
eccc1d2
@jorbakk
Disable completion hinting with sqlite backend
1369abb
@jorbakk
Moving hint words to input works better
70e9894
@jorbakk
Insert hint at end of input in edit_refresh()
3c995cb
@jorbakk
Added dump_editor()
4d313ee
@jorbakk
Fixed returning null as history entry with idx 0
6931db4
@jorbakk
Clear hint when there's no history entry
49dfa1b
@jorbakk
Browsing history with UP / DOWN looks more correct, now
b4f4389
@jorbakk
Handle history browsing with offsets other than -1, 1 (though not nee…
85be32f 
…ded)
jorbakk added 30 commits March 26, 2023 09:04
@jorbakk
Updated todos
dbd83ed
@jorbakk
Replace (void) by ic_unused
9dac5c4
@jorbakk
Clear hint on ESC when cursor is at start of line
42d42a7
@jorbakk
Split out edit_update_history_hint()
4aca115
@jorbakk
Update history hint when deleting from input
f216cba
@jorbakk
Handle deletion of input and hinting better
19963fe
@jorbakk
Removed option to disable history hint while typing
1b22384 
This would lead to inconsistencies with showing/hiding and handling
the history entries.
@jorbakk
Delete hint when input is modified but empty
d35f2a7
@jorbakk
Some refactoring
0a8f7f6
@jorbakk
Fixed history index not reset when prefix changed
8e789be
@jorbakk
Setting history_idx seems to be more consistent, now
1bb8469
@jorbakk
Some cleanup of the history API
86b8b5f
@jorbakk
Updated original file backend for history to new API
d341d34 
Implementation is most likely not fully correct ... it's just to
show that the original backend should also work with the new API.
@jorbakk
More clean up of history API, separate public and private API
3df0865
@jorbakk
Implemented all public API calls with sqlite backend
0e934f0 
Implementation not tested ...
@jorbakk
Set timestamp when pushing history entry
629a190
@jorbakk
Update timestamp if entry is a duplicate
2d6a63f
@jorbakk
Renamed table cmd to cmds
d07f75e
@jorbakk
Updated todos
6c97c62
@jorbakk
Cosmetics
c9b36b9
@jorbakk
Updated fixmes
23d0962
@jorbakk
Clear hint when entering the extra menu
7947435
@jorbakk
Updated todo
c811ff4
@jorbakk
Clear history hint when completing directly with only one completion
dfc8c31
@jorbakk
Always clear the hint when returning with a completion
d2c056b
@jorbakk
Some cleanup
93d584d
@jorbakk
Added word wise stepping through history with Alt-.
3880ca5
@jorbakk
Skip leading whitespace when browsing history word-wise
8d0a0d7
@jorbakk
Delete hint when completing a prefix
ff84319
@jorbakk
Added a separate history idx for browsing history by word
29e76c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jorbakk