refactor(tui): extract input handling helpers in App#62
Merged
daisuke8000 merged 1 commit intomainfrom Dec 20, 2025
Merged
Conversation
Refactor the monolithic handle_key() method (254 lines) into focused helper methods for better readability and maintainability: - handle_overlay_keys(): RecordDetail and Help overlay handling - handle_search_mode_keys(): Search input mode processing - handle_global_keys(): Quit, help, tab switching, refresh - handle_escape_key(): Navigation back logic - handle_refresh(): Data reload for current view - handle_enter_key(): Content-specific Enter actions The new handle_key() is now a simple 25-line orchestrator that delegates to specialized handlers in priority order: 1. Overlay keys (highest priority) 2. Search mode keys 3. Global keybindings 4. Enter key for content actions 5. Remaining keys to ContentPanel This separation improves: - Testability: Each handler can be tested independently - Debugging: Easier to locate issues in specific handlers - Maintenance: Changes are isolated to relevant handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_key()method (254 lines) into focused helper methodsChanges
Before: Single monolithic method
After: Orchestrator with specialized handlers
New helper methods
handle_overlay_keys()handle_search_mode_keys()handle_global_keys()handle_escape_key()handle_refresh()handle_enter_key()handle_key()Benefits
Test plan
cargo test --package mbr-tui- All 32 tests passcargo clippy --package mbr-tui- No warningscargo fmt- Applied