refactor(config): simplify configuration by removing profiles and email#69
Merged
daisuke8000 merged 2 commits intomainfrom Dec 21, 2025
Merged
Conversation
Remove legacy multi-profile and email-based authentication support, adopting a simpler 12-factor app style configuration. Changes: - Remove `Profile` struct and multi-profile HashMap from Config - Remove `--profile` CLI option - Remove `--email` option and `validate_email()` function - Simplify Config to single `url: Option<String>` field - Simplify ConfigService to handle only URL - Update TUI service to use `get_url()` instead of `get_profile()` - Update documentation to reflect simplified configuration Configuration now uses: - `MBR_API_KEY` env var for authentication (required) - `MBR_URL` env var or config.toml for server URL (optional)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configstruct fromprofiles: HashMap<String, Profile>to singleurl: Option<String>Changes
Profilestruct and multi-profile HashMap--profileCLI option--emailoption andvalidate_email()functionConfigServiceto handle only URLget_url()instead ofget_profile()Configuration (After)
Environment variables:
MBR_API_KEYMBR_URLTest plan