Use gitlab project ID instead of project name#976
Closed
farabi wants to merge 2 commits intodanger:masterfrom
Closed
Use gitlab project ID instead of project name#976farabi wants to merge 2 commits intodanger:masterfrom
farabi wants to merge 2 commits intodanger:masterfrom
Conversation
Use gitlab project id. when not defined. use project name instead. Add doc about gitlab project id. Update gitlabApi unit tests, and repo slug documentation.
farabi
changed the title
Member
|
Why was this closed? Did you get this working some other way? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#969 Here i added an environment variable for gitlab project id called
DANGER_GITLAB_PROJECT_IDAdd added some doc about that. and updated GitlabAPI unit tests.
Project name will be used if project id variable is not defined (so no breaking changes).