fix(vpcPermissions): Make VPC permissions are Optional #509
Open
charanack wants to merge 5 commits intodaniel-cottone:masterfrom
Open
fix(vpcPermissions): Make VPC permissions are Optional #509charanack wants to merge 5 commits intodaniel-cottone:masterfrom
charanack wants to merge 5 commits intodaniel-cottone:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Currently, VPC permissions are added by default but they should be optional. if the user provides VPC config then VPC permission should automatically be attached to the role. this PR address this issue.
✅ Closes Issue