Skip to content

Update package.json #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update package.json #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"peerDependencies": {
"d3": "^5.5.0",
"react": "^16.4.1"
"react": "^17.0.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok on allowing react 16 or greater, but we shouldn't block clients to use react 16.

Suggested change
"react": "^17.0.2"
"react": ">=16.4.1"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could create a new version for this

},
"devDependencies": {
"@babel/cli": "7.6.0",
Expand All @@ -64,7 +64,7 @@
"eslint-plugin-promise": "4.2.1",
"eslint-plugin-react": "7.14.3",
"eslint-plugin-standard": "4.0.1",
"html-webpack-plugin": "2.30.1",
"html-webpack-plugin": "^4.0.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if this does need other dependency updates 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

"http-server": "^0.12.1",
"husky": "3.0.5",
"jest": "24.9.0",
Expand All @@ -74,17 +74,17 @@
"npm-run-all": "4.1.5",
"prettier": "1.19.1",
"query-string": "6.8.3",
"react": "^16.4.1",
"react": "^17.0.2",
"react-addons-test-utils": "15.6.2",
"react-dom": "^16.4.2",
"react-dom": "17.0.0",
"react-editable-json-tree": "2.2.1",
"react-jsonschema-form": "1.0.4",
"react-test-renderer": "16.9.0",
"react-toastify": "5.5.0",
"react-tooltip": "3.11.6",
"style-loader": "0.18.2",
"typescript": "3.8.3",
"webpack": "4.41.6",
"webpack": "^4.46.0",
"webpack-bundle-analyzer": "^3.0.3",
"webpack-cli": "3.3.8",
"webpack-dev-server": "^3.1.14",
Expand Down Expand Up @@ -115,3 +115,4 @@
}
}
}