omit patternDescription from yaml schema#891
Open
7opf wants to merge 1 commit intodanielgtaylor:mainfrom
Open
Conversation
Author
|
It's not clear to me whether this is the correct fix. I just saw that the |
Collaborator
|
Thanks for opening this @7opf! Looking back, this was implemented in #323 by @purin-dev, and @danielgtaylor directly added the line to our JSON marshaler. I can't tell if it's intentional for it to be within the schema or not; however, I do agree that I'm not sure it should be (at best, it should be marshaled as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON Schema Validation defines the pattern keyword, but does not define any patternDescription keyword. This keyword seems to be used only by Huma.