fix: broken relative imports for proto output types generation#555
Open
Dimitrioglo wants to merge 6 commits intodanielgtaylor:masterfrom
Open
fix: broken relative imports for proto output types generation#555Dimitrioglo wants to merge 6 commits intodanielgtaylor:masterfrom
Dimitrioglo wants to merge 6 commits intodanielgtaylor:masterfrom
Conversation
8bef2b8 to
2dd20e3
Compare
Author
|
Can you check please? @danielgtaylor, @Gobot1234 |
Collaborator
|
Please can you add a test for this case? |
Author
Done, can you check? |
Author
|
@Gobot1234 Can you process with review? |
Collaborator
|
Please can you run the code through black |
Author
|
@Gobot1234 fixed pre-commit hooks issues |
Author
|
@Gobot1234 is any chance this fix will be released in next weeks/month? |
Author
|
@Gobot1234 , @danielgtaylor Any news guys? |
Gobot1234
reviewed
Mar 19, 2024
Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com>
Gobot1234
approved these changes
Mar 23, 2024
Collaborator
|
Not sure why linux CI is failing |
|
Hi @danielgtaylor , i am also facing the broken relative imports issue. when can we merge this PR ? |
Collaborator
|
It will be merged when the CI is fixed |
|
Results seem to have aged out, but I think the lack of this PR is why betterproto doesn't work with the Protobufs I'm trying to use now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist