Open
Conversation
This is a fix for the Greek letter Theta (https://en.wikipedia.org/wiki/Theta) which is now replaced by O which is completely irrelevant. I believe this was a mistake due to the cyrilic ө (https://en.wiktionary.org/wiki/%D3%A8) which is correctly replaced by ο (it is left untouched in my proposal). P.S. I am a Greek native speaker
Author
|
I just noticed that there is another PR for this issue I think that the author of this PR also changes the Cyrilic letter ө which is a mistake. |
nikosv
added a commit
to nikosv/framework
that referenced
this pull request
Jun 30, 2019
This is a fix for the Greek letter Theta (https://en.wikipedia.org/wiki/Theta) which is now replaced by O which is completely irrelevant. I believe this was a mistake in the original code due to the cyrilic ө (https://en.wiktionary.org/wiki/%D3%A8) which is correctly replaced by ο (it is left untouched in my proposal). I have also created a PR to the original source danielstjules/Stringy#193 but the project seems abandonded. However my changes were copied on a better mantained fork https://github.com/voku/Stringy P.S. I am a Greek native speaker
taylorotwell
pushed a commit
to illuminate/support
that referenced
this pull request
Jun 30, 2019
This is a fix for the Greek letter Theta (https://en.wikipedia.org/wiki/Theta) which is now replaced by O which is completely irrelevant. I believe this was a mistake in the original code due to the cyrilic ө (https://en.wiktionary.org/wiki/%D3%A8) which is correctly replaced by ο (it is left untouched in my proposal). I have also created a PR to the original source danielstjules/Stringy#193 but the project seems abandonded. However my changes were copied on a better mantained fork https://github.com/voku/Stringy P.S. I am a Greek native speaker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the Greek letter Theta (https://en.wikipedia.org/wiki/Theta) which is now replaced by O which is completely irrelevant.
I believe this was a mistake due to the cyrilic ө (https://en.wiktionary.org/wiki/%D3%A8) which is correctly replaced by ο (it is left untouched in my proposal).
P.S. I am a Greek native speaker