Skip to content

Add Related Section#28

Open
cliffordfajardo wants to merge 1 commit intodanielstjules:masterfrom
cliffordfajardo:cliffordfajardo-patch-1
Open

Add Related Section#28
cliffordfajardo wants to merge 1 commit intodanielstjules:masterfrom
cliffordfajardo:cliffordfajardo-patch-1

Conversation

@cliffordfajardo
Copy link

What is the change

Add "Related Section" referencing ESlint's magic number rule.

Purpose of Change

  1. Expose more people to the awesome-ness of no magic numbers.
  2. ESlint is constantly updating and maintaining their version of 'no magic numbers' linter rule that works with modern javascript & typescript. It seems like this repo hasn't been updated in a while.
  3. Most people when they search 'no magic numbers' in javascript frequently land here. It would be nice for them to also know that it exists in ESlint as part of a core rule.

Questions

Are you ok with putting a notice in the beginning of the README, indicating to user's that it's worth checking out ESlint's version in the spirit of getting more people exposed to 'no magic numbers'?

Add "Related Section" referencing ESlint's magic number rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant