implement parsing for UciResponse#7
Open
SiriusAshling wants to merge 1 commit intodannyhammer:mainfrom
Open
Conversation
resolves dannyhammer#1 Note: This commit extends the impact of dannyhammer#4. The relevant codepath mentioned there is now present regardless of the `types` feature. As a consequence, compilation currently always fails with the `validate-promotion-moves` feature Not a breaking change, the shape of `UciResponse` remains unchanged. This required some gymnastics in particular when parsing uci moves: `UciCommand` contained `UciMove`s instead of `String`s with the `types` feature enabled and the parsing infrastructure was specialized for this. Since `UciResponse` stores uci moves as `String` even with the `types` feature, the alternative parsing functions `recognize_uci_move`, `recognize_moves` and `recognize_moves_after` were created to allow always parsing into `String`. Tests are a mix of made-up and grabbed from the UCI spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this,
UciResponseimplementsFromStrand hasUciResponse::newmirroringUciCommand.Probably shouldn't be merged until #4 is fixed (see commit description).
The initial commit does not break the shape of
UciResponse, but it might be worth to consider a breaking change to allow parsing intoUciMovedirectly the same way that it works forUciCommand. Otherwise the documentation for thetypesfeature might be misleading.Another consideration might be to refine the types inside
UciInfo, which are currently allStrings. For example,depthcould beOption<u32>, which would be in line with thedepthfield ofUciSearchOptions.refutationcould be a struct with a separateStringfor the move being refuted andcurrlinea struct withOption<u32>for the cpu number.Let me know if you want any of those (or other) changes.