Skip to content

Conversation

@salaboy
Copy link
Collaborator

@salaboy salaboy commented Aug 26, 2025

This reverts commit a782438.

Description

This comment was created part of the release automation and it is wrong to target master.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners August 26, 2025 12:41
This reverts commit a782438.

Signed-off-by: salaboy <[email protected]>
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear to me why we are reverting this. Please update your PR description with reasoning.

As far as I can tell, the publish was successful and the tag was created, so we should not revert this. In the future, we should always create an RC first, then the official version once the fix is validated.

@salaboy salaboy closed this Aug 26, 2025
@salaboy salaboy reopened this Aug 26, 2025
@salaboy salaboy closed this Aug 26, 2025
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.73%. Comparing base (d759c53) to head (0f2edc0).
⚠️ Report is 201 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1519      +/-   ##
============================================
+ Coverage     76.91%   78.73%   +1.82%     
- Complexity     1592     1919     +327     
============================================
  Files           145      237      +92     
  Lines          4843     5926    +1083     
  Branches        562      610      +48     
============================================
+ Hits           3725     4666     +941     
- Misses          821      938     +117     
- Partials        297      322      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants