-
Notifications
You must be signed in to change notification settings - Fork 223
Increase atMost condition to at most 45 seconds #1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Matheus Cruz <[email protected]>
|
@mcruzdev I am wondering why we need to increase to such a high number. Also could you please sign your commit |
artur-ciocanu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
============================================
+ Coverage 76.91% 78.67% +1.76%
- Complexity 1592 1957 +365
============================================
Files 145 217 +72
Lines 4843 5970 +1127
Branches 562 661 +99
============================================
+ Hits 3725 4697 +972
- Misses 821 932 +111
- Partials 297 341 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mcruzdev I still see issues like these: |
|
+1 I think this needs a bit more investigation here beyond upping the time since it still fails. Appreciate the efforts here 🎉 |
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1603
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: