Skip to content

Conversation

@schultek
Copy link

@schultek schultek commented Dec 4, 2025

For #4299


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

Copy link
Contributor

@Markzipan Markzipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!

@schultek schultek marked this pull request as ready for review December 5, 2025 13:23
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Copy link
Contributor

@Markzipan Markzipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to submit after changelog/version updates

@schultek schultek force-pushed the custom-sdk-build-options branch from cb30123 to 36cadd8 Compare December 5, 2025 23:19
@schultek
Copy link
Author

schultek commented Dec 5, 2025

Thanks for the approval.

I did one renaming of the option related to allowing unsafe modules, because I had a read through the webdev issue and it seems like this is more related than I initially though. Since I don't want to conflict here with anything discussed there I opted for the renaming prefixed with "unsafe" and also not publicly documenting this flag.

Lmk if the changelog is ok like this, or if I should document the other added flags explicitly.

@schultek schultek force-pushed the custom-sdk-build-options branch from 36cadd8 to de73a9a Compare December 5, 2025 23:23
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:build 4.0.3 already published at pub.dev
package:build_config 1.2.0 already published at pub.dev
package:build_daemon 4.1.1 already published at pub.dev
package:build_modules 5.1.4 already published at pub.dev
package:build_runner 2.11.0-wip WIP (no publish necessary)
package:build_test 3.5.5-wip WIP (no publish necessary)
package:build_web_compilers 4.4.6 ready to publish build_web_compilers-v4.4.6
package:scratch_space 1.2.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@Markzipan
Copy link
Contributor

Changelog looks fine! 'Non-user-visible' changes don't need to be included there, so your reasoning's sound. Pulling @bkonyi into this as an FYI; they've been following some efforts to allow these kinds of "flutter can use this lib but I can't" kind of situations.

@@ -1,3 +1,7 @@
## 4.4.6

- Add build options to customize the SDK used for compiling to js and wasm.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documented anywhere? How would one use it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently not, but I'd like to.
Where would be a good place to document this? I think this shouldn't be too visible (so not in Readme) since it's quite a special case.

@kevmoo
Copy link
Member

kevmoo commented Dec 7, 2025

The other build options are in the readme, right?

It's fine to add an "advanced" section or similar. Just don't want this to get lost in the weeds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants