Table of Contents for package admin page. #8101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Oct 3, 2024
isoos
commented
- Deployed to staging for verification.
- The floating part is extremely limited, but provides 80% of the value for very little investment, and we can iterate on it later. When the display is narrow, the table of contents is inlined as part of the admin page.
- Floating example:
isoos
changed the title
|
Note: removed the floating part for now, let's iterate on it separately. |
|
We should probably deploy this to staging. |
|
@sigurdm and @szakarias do you have opinions? |
sigurdm
reviewed
Oct 7, 2024
| child: d.div( | ||
| classes: ['pub-toc'], | ||
| children: [ | ||
| d.div(child: d.b(text: 'Contents')), |
There was a problem hiding this comment.
Open question. Should we (specifically for the admin page) call this
Suggested change
| d.div(child: d.b(text: 'Contents')), | |
| d.div(child: d.b(text: 'Sections')), |
There was a problem hiding this comment.
I think it is fine to call it Sections on any page really. It is not that we can guarantee that a random README actually has a content, only the section headers.
|
There's ...something.. about the layout. I cannot quite put words to it. But I think it is good enough for starters. We can always iterate on it. |
sigurdm
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.