Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Oct 7, 2024

Fixes #8106

Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings, just a slight concern about the churn we add here.

But I can also see more churn by adding more linters/tools that everyone will have to configure/install.

@isoos
Copy link
Collaborator Author

isoos commented Oct 7, 2024

Having an unused variable is pretty harmless is it not?

I'd consider it the same as unused code/variable lints in the Dart code. Since we filter out those, we should filter out the same here.

@isoos isoos merged commit be26349 into dart-lang:master Oct 7, 2024
32 checks passed
@isoos isoos deleted the fix-css-variable branch October 7, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

site-header-nav backround color not displaying in mobile size

2 participants