Skip to content

Use the same title attribute for both download count widget. #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

Use the same title attribute for both download count widget. #9004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/lib/frontend/templates/_consts.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ const myPackagesTabTitle = 'Packages';
const myLikedPackagesTabTitle = 'Likes';
const myActivityLogTabTitle = 'Activity log';

/// Text to display when the mouse pointer is hovering over the download count number.
const titleFor30DaysDownloadCounts =
'Number of downloads of this package during the past 30 days';

class SdkDict {
final String topSdkPackages;
final String searchPackagesLabel;
Expand Down
6 changes: 2 additions & 4 deletions app/lib/frontend/templates/views/pkg/labeled_scores.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'package:_pub_shared/format/number_format.dart';

import '../../../dom/dom.dart' as d;
import '../../_consts.dart';

d.Node labeledScoresNode({
required String package,
Expand Down Expand Up @@ -36,10 +37,7 @@ d.Node labeledScoresNode({
child: _labeledScore('points', grantedPubPoints?.toString(), sign: ''),
),
d.div(
attributes: {
'title':
'Number of downloads of this package during the past 30 days',
},
attributes: {'title': titleFor30DaysDownloadCounts},
classes: ['packages-score', 'packages-score-downloads'],
child: _labeledScore(
'downloads',
Expand Down
14 changes: 12 additions & 2 deletions app/lib/frontend/templates/views/pkg/score_tab.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@ import 'dart:convert';
import 'package:_pub_shared/data/download_counts_data.dart';
import 'package:_pub_shared/format/number_format.dart';
import 'package:pana/models.dart';
import 'package:pub_dev/frontend/dom/material.dart';
import 'package:pub_dev/service/download_counts/backend.dart';
import 'package:pub_dev/shared/utils.dart';

import '../../../../scorecard/models.dart' hide ReportStatus;
import '../../../../shared/urls.dart' as urls;
import '../../../dom/dom.dart' as d;
import '../../../dom/material.dart';
import '../../../static_files.dart';
import '../../_consts.dart';

/// Renders the score page content.
d.Node scoreTabNode({
Expand Down Expand Up @@ -337,14 +338,20 @@ d.Node _likeKeyFigureNode(int? likeCount) {

d.Node _downloadCountsKeyFigureNode(int? downloadCounts) {
if (downloadCounts == null) {
return _keyFigureNode(value: '--', supplemental: '', label: 'downloads');
return _keyFigureNode(
value: '--',
supplemental: '',
label: 'downloads',
title: titleFor30DaysDownloadCounts,
);
}
return _keyFigureNode(
value:
'${compactFormat(downloadCounts).value}'
'${compactFormat(downloadCounts).suffix}',
supplemental: '',
label: 'downloads',
title: titleFor30DaysDownloadCounts,
);
}

Expand Down Expand Up @@ -373,10 +380,13 @@ d.Node _keyFigureNode({
required String value,
required String supplemental,
required String label,
String? title,
List<String>? classes,
}) {
final attributes = title == null ? null : {'title': title};
return d.div(
classes: ['score-key-figure', ...?classes],
attributes: attributes,
children: [
d.div(
classes: ['score-key-figure-title'],
Expand Down
2 changes: 1 addition & 1 deletion app/test/frontend/golden/pkg_score_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ <h3 class="detail-lead-title">Metadata</h3>
</div>
<div class="score-key-figure-label">pub points</div>
</div>
<div class="score-key-figure">
<div class="score-key-figure" title="Number of downloads of this package during the past 30 days">
<div class="score-key-figure-title">
<span class="score-key-figure-value">--</span>
<span class="score-key-figure-supplemental"></span>
Expand Down
2 changes: 1 addition & 1 deletion app/test/frontend/golden/pkg_score_page_with_downloads_chart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ <h3 class="detail-lead-title">Metadata</h3>
</div>
<div class="score-key-figure-label">pub points</div>
</div>
<div class="score-key-figure">
<div class="score-key-figure" title="Number of downloads of this package during the past 30 days">
<div class="score-key-figure-title">
<span class="score-key-figure-value">--</span>
<span class="score-key-figure-supplemental"></span>
Expand Down
2 changes: 1 addition & 1 deletion app/test/task/testdata/goldens/packages/oxygen/score.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ <h3 class="detail-lead-title">Metadata</h3>
</div>
<div class="score-key-figure-label">pub points</div>
</div>
<div class="score-key-figure">
<div class="score-key-figure" title="Number of downloads of this package during the past 30 days">
<div class="score-key-figure-title">
<span class="score-key-figure-value">--</span>
<span class="score-key-figure-supplemental"></span>
Expand Down
2 changes: 1 addition & 1 deletion app/test/task/testdata/goldens/packages/oxygen/versions/1.0.0/score.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ <h3 class="detail-lead-title">Metadata</h3>
</div>
<div class="score-key-figure-label">pub points</div>
</div>
<div class="score-key-figure">
<div class="score-key-figure" title="Number of downloads of this package during the past 30 days">
<div class="score-key-figure-title">
<span class="score-key-figure-value">--</span>
<span class="score-key-figure-supplemental"></span>
Expand Down
Loading