Refactoring cloud compute instance creation with external state of banned zones. #9115
+213
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Dec 8, 2025
| // Map from zone to DateTime when zone is allowed again | ||
| final zoneBannedUntil = <String, DateTime>{ | ||
| for (final zone in compute.zones) zone: DateTime(0), | ||
| ...state.zoneBannedUntil, |
Member
There was a problem hiding this comment.
It's remove the old bans that are too old, so zoneBannedUntil can't grow indefinitely, should compute zones over time be large.
Collaborator
Author
There was a problem hiding this comment.
Note: the current code relies on the zoneBannedUntil to contain all available zones. I think it is better to rely on the zones list directly, will refactor.
Collaborator
Author
There was a problem hiding this comment.
Actually, will do this in a follow-up
Comment on lines
140
to
148
| // A zone being exhausted is normal operations, we just use another | ||
| // zone for 15 minutes. | ||
| _log.info( | ||
| 'zone resources exhausted, banning ${e.zone} for 30 minutes', | ||
| e, | ||
| st, | ||
| ); | ||
| // Ban usage of zone for 30 minutes | ||
| banZone(e.zone, minutes: 30); |
Member
There was a problem hiding this comment.
15 or 30 minutes, did we change this recently.
Code and comments are out of sync.
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.