-
Notifications
You must be signed in to change notification settings - Fork 736
add initial draft of dot shorthands feature #6941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for writing this up.
child: Text('Hello') | ||
) | ||
); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't know if we do this, but do we ever link to the actual spec in documentation? I feel like if users wanted a full, exhaustive rundown of the feature, it'd be nice to get to the spec to read. @antfitch Do you have any guidance here?
@connie-ooi and @kallentu, after you've finished your review, let me know and I'll start my review. I'll be focusing on flow. If any technical changes are required, @kallentu, I'll pull you in. |
Adds the official "Built with Jaspr" badge to the footer, replacing the current text link. <img width="1006" height="249" alt="Screenshot of the footer with the new 'Built with Jaspr' badge." src="https://github.com/user-attachments/assets/58bd2684-84d5-44e2-8bf6-22a649b30877" /> --------- Co-authored-by: Parker Lougheed <[email protected]>
…#6938) Before: <img width="420" alt="Showcase of incorrect rendering" src="https://github.com/user-attachments/assets/bed2a9a1-0df2-466d-a204-3f7cdc8e4091" /> After: <img width="420" alt="Showcase of fixed rendering" src="https://github.com/user-attachments/assets/85e7cda3-103e-43e2-b5c4-7c2852ba8cb7" /> **Staged:** https://dart-dev--pr6938-fix-conditional-expressions-rendering-4ordzkkp.web.app/language/operators#conditional-expressions
Resolves dart-lang#6933 This only makes the filtering section a client component. Hiding and showing the specific lint rule cards is done through manual dom manipulation. --------- Co-authored-by: Parker Lougheed <[email protected]>
Migrates the inject_dartpad script to a Jaspr client component. Note: the EmbeddedDartPad class from `site_shared` is for now just copied into this repo, we can contribute it back once flutter migration is done. --------- Co-authored-by: Parker Lougheed <[email protected]>
…cks (dart-lang#6952) Issue: When I copy the code blocks, it also copies the terminal prefixes (i.e. $, PS, C:// etc) too. I see there is already a function stripping them, but it had a minor issue which is fixed in this PR. **Steps to reproduce** - Go to https://dart.dev/get-dart#install - Click on copy button on the right hand side of the command - Paste it anywhere **Issue** It copies the terminal prefixes too. Which one has to manually remove. <img width="524" height="36" alt="Screenshot From 2025-10-17 22-16-22" src="https://github.com/user-attachments/assets/a488f652-87dc-4041-a61c-3873ac1872cb" /> **Expected** Only copy the command part. <img width="524" height="36" alt="Screenshot From 2025-10-17 22-16-38" src="https://github.com/user-attachments/assets/fe77dd71-49df-42f3-ac4a-1908a544f606" />
Automatically computes a hash for the generated `main.css` file and makes it accessible from Dart code. Then appends it as a query parameter to the `main.css` link from each page. This allows changes to the CSS to indicate to clients to pull the updated version rather than the potentially outdated one from cache. Resolves dart-lang#6946
This prevents the icon's ID being treated as text in some scenarios.
Updates `package:opal` to version 0.1.0 which adds support for syntax highlighting Swift, Kotlin, and Obj-C. It also significantly improves syntax highlighting for YAML.
…g#6948) Fix the typo by replacing a dot with a comma in the middle of the sentence. --- Co-authored-by: Amanda Fitch <[email protected]>
Part of dart-lang#6853. Touches: - Homepage gallery behavior - Expandable glossary cards - TOC (Inline dropdown & sidebar) Resolves dart-lang#6937
…art-lang#6955) **Before** Scrollbar is visible for non-overflowing code blocks. <img width="600" alt="Before" src="https://github.com/user-attachments/assets/ceb32e23-fd67-4841-99df-aacfece99d2d" /> --- **After** Scrollbar is hidden by default and only visible for overflowing code blocks. <img width="600" alt="After" src="https://github.com/user-attachments/assets/c438bbfa-083f-4acd-a455-81eaf6ba4f91" /> --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. - [x] This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/site-www/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Code changes should generally follow the [Dart style guide](https://dart.dev/effective-dart) and use `dart format`. - Updates to [code excerpts](https://github.com/dart-lang/site-shared/blob/main/packages/excerpter) indicated by `<?code-excerpt` need to be updated in their source `.dart` file as well. </details>
Add a page for `dart install` and various fixes w.r.t. the build hooks. This should round out the final dart.dev page for all the features related to build hooks. We have a hooks page, a dart install page, and a dart build page. Fixes dart-lang#6881 **Staged:** https://dart-dev--pr6943-dart-build-page-wv4y99wr.web.app/tools/dart-build --------- Co-authored-by: connie-ooi <[email protected]> Co-authored-by: Amanda Fitch <[email protected]> Co-authored-by: Parker Lougheed <[email protected]>
Visit the preview URL for this PR (updated for commit 081ed59): |
Resolves #6285
Resolves #6689