Skip to content

Display plugin setup instructions after apps init flow, remove empty files after template rendering#4549

Merged
pkosiec merged 8 commits intomainfrom
pkosiec/rm-hardcoded-plugin-paths
Feb 27, 2026
Merged

Display plugin setup instructions after apps init flow, remove empty files after template rendering#4549
pkosiec merged 8 commits intomainfrom
pkosiec/rm-hardcoded-plugin-paths

Conversation

@pkosiec
Copy link
Member

@pkosiec pkosiec commented Feb 19, 2026 •
edited
Loading

Changes

  • Show setup notes for plugins which have such instructions (needed for Lakebase plugin temporarily)
  • Remove hardcoded paths for analytics plugin - this will be handled purely by Go templates in the template itself
  • Remove empty files and directories after template rendering
  • Setup listers for postgres resource
  • Run "postinit" npm command in context of template if it exists - reverted as we don't need it for now

Those changes need to be synchronized with AppKit where we add the templatePaths property in the manifest.

Why

See also https://databricks.atlassian.net/browse/LKB-9681

Screenshot

image

Demo

(just the listers for future Lakebase plugin changes databricks/appkit#132)

Screen.Recording.2026-02-24.at.15.43.45.mov

@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Feb 19, 2026 •
edited
Loading

Commit: 9d74e9d

Run: 22479451774

Env 🟨​KNOWN 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
🟨​ aws linux 7 1 7 268 768 7:52
🟨​ aws windows 7 1 7 270 766 5:52
💚​ aws-ucws linux 8 7 364 684 5:59
💚​ aws-ucws windows 8 7 366 682 5:40
💚​ azure linux 2 9 271 766 7:25
💚​ azure windows 2 9 273 764 4:18
💚​ azure-ucws linux 2 9 369 680 9:50
💚​ azure-ucws windows 2 9 371 678 6:25
💚​ gcp linux 2 9 267 769 6:22
💚​ gcp windows 2 9 269 767 5:14
15 interesting tests: 7 KNOWN, 7 SKIP, 1 RECOVERED
Test Name aws linux aws windows aws-ucws linux aws-ucws windows azure linux azure windows azure-ucws linux azure-ucws windows gcp linux gcp windows
🟨​ TestAccept 🟨​K 🟨​K 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/resources/permissions 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions 🟨​K 🟨​K 💚​R 💚​R 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions 🟨​K 🟨​K 💚​R 💚​R 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct 🟨​K 🟨​K 💚​R 💚​R
🟨​ TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform 🟨​K 🟨​K 💚​R 💚​R
🙈​ TestAccept/bundle/resources/postgres_branches/basic 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/recreate 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/update_protected 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_branches/without_branch_id 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/postgres_endpoints/recreate 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/synced_database_tables/basic 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
💚​ TestAccept/ssh/connection 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 24 slowest tests (at least 2 minutes):
duration env testname
5:29 azure-ucws linux TestSecretsPutSecretStringValue
3:51 gcp linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:38 gcp windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:22 aws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:12 azure-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:12 gcp windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:09 gcp linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:58 azure linux TestSecretsPutSecretStringValue
2:48 aws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:43 aws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:43 aws-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:40 aws-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:39 aws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:36 aws-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:34 aws-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:22 gcp linux TestSecretsPutSecretStringValue
2:16 azure-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:16 azure linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:16 azure-ucws windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:14 azure windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:11 azure windows TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:08 azure linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:07 azure-ucws linux TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:05 aws linux TestSecretsPutSecretStringValue

@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from be69f43 to 4814591 Compare February 20, 2026 09:52
@pkosiec pkosiec changed the title Read plugin-owned paths from manifest during the apps init Run a postinit template command after apps init flow Feb 20, 2026
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from f568792 to 6f37920 Compare February 23, 2026 12:47
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from 6f37920 to b0d7806 Compare February 23, 2026 16:50
@pkosiec pkosiec changed the title Run a postinit template command after apps init flow Display plugin setup instructions after apps init flow Feb 23, 2026
@pkosiec pkosiec changed the title Display plugin setup instructions after apps init flow Display plugin setup instructions after apps init flow, remove hardcoded plugin paths Feb 23, 2026
@pkosiec pkosiec changed the title Display plugin setup instructions after apps init flow, remove hardcoded plugin paths Display plugin setup instructions after apps init flow Feb 23, 2026
@pkosiec pkosiec changed the title Display plugin setup instructions after apps init flow Display plugin setup instructions after apps init flow, remove empty files after template rendering Feb 23, 2026
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from 4218939 to ba9c6f2 Compare February 23, 2026 16:59
@pkosiec pkosiec marked this pull request as ready for review February 23, 2026 17:00
@pkosiec pkosiec requested a review from a team as a code owner February 23, 2026 17:00
This was referenced Feb 23, 2026
Merged
Merged
Closed
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from ba9c6f2 to 17fd2f5 Compare February 24, 2026 14:48
@pkosiec pkosiec force-pushed the pkosiec/rm-hardcoded-plugin-paths branch from 17fd2f5 to 9d74e9d Compare February 27, 2026 08:52
@pkosiec pkosiec enabled auto-merge February 27, 2026 09:10
@pkosiec pkosiec added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit 93db3ca Feb 27, 2026
18 checks passed
@pkosiec pkosiec deleted the pkosiec/rm-hardcoded-plugin-paths branch February 27, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarioCadenas MarioCadenas MarioCadenas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkosiec @eng-dev-ecosystem-bot @MarioCadenas