Add per-resource-type state sizes and action counts to deploy telemetry#4629
Open
shreyas-goenka wants to merge 1 commit intomainfrom
Open
Add per-resource-type state sizes and action counts to deploy telemetry#4629shreyas-goenka wants to merge 1 commit intomainfrom
shreyas-goenka wants to merge 1 commit intomainfrom
Conversation
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
force-pushed
the
deploy-telemetry
branch
from
8ad5777 to
3c9405e
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: d04bdb0
24 interesting tests: 7 KNOWN, 7 SKIP, 5 BUG, 4 flaky, 1 RECOVERED
Top 27 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
deploy-telemetry
branch
from
3c9405e to
c55b40e
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Track two new experimental metrics in BundleDeployEvent: - resource_state_size_bytes: per-resource-type config sizes computed from the bundle YAML config (engine-independent) - resource_action_counts: per-resource-type CRUD action counts from deploy plan, including permissions and grants Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
force-pushed
the
deploy-telemetry
branch
from
c55b40e to
d04bdb0
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
reviewed
Mar 3, 2026
Contributor
andrewnester
left a comment
andrewnester
left a comment
There was a problem hiding this comment.
Could you clarify the reasoning why we need to track these fields?
| jobs: | ||
| job_one: | ||
| name: job one | ||
| permissions: |
Contributor
There was a problem hiding this comment.
Why do we need this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource_state_size_bytesexperimental telemetry field tracking per-resource-type config sizes in bytes, computed from the bundle YAML config (engine-independent, consistent across terraform and direct)resource_action_countsexperimental telemetry field tracking per-resource-type CRUD action counts from the deploy plan (e.g.,jobs.create,pipelines.update,permissions.create)Test plan
make buildpassesmake lintfullpasses (0 issues)go test ./acceptance -run TestAccept/bundle/telemetry -v)go test ./bundle/phases/...)resource_state_size_bytesvalues (config-based, not state-file-based)🤖 Generated with Claude Code