Conversation
Passing a nil context to the log functions is an error; remove the fallback to context.Background() so callers are forced to pass a valid context. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pietern
requested review from
andrewnester,
anton-107,
denik,
shreyas-goenka and
simonfaltum
as code owners
Collaborator
|
Commit: 863afd2
27 interesting tests: 8 FAIL, 7 KNOWN, 7 SKIP, 3 flaky, 1 BUG, 1 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
denik
approved these changes
Mar 5, 2026
pietern
added a commit
that referenced
this pull request
Mar 5, 2026
## Summary - Add a gorules lint rule that flags `context.Background()` usage in all files except `main.go`, suggesting `t.Context()` in tests or passing context from the caller - Add context guidelines to AGENTS.md Builds on #4655, #4656, and #4657. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nilcontext fallback from functions inlibs/logFrom https://pkg.go.dev/context:
🤖 Generated with Claude Code