Fix #729 and #731: Telemetry lifecycle management#734
Open
msrathore-db wants to merge 2 commits intomainfrom
Open
Fix #729 and #731: Telemetry lifecycle management#734msrathore-db wants to merge 2 commits intomainfrom
msrathore-db wants to merge 2 commits intomainfrom
Conversation
msrathore-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
msrathore-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
samikshya-db
approved these changes
Feb 4, 2026
Contributor
samikshya-db
left a comment
samikshya-db
left a comment
There was a problem hiding this comment.
Thanks for the fix!
samikshya-db
reviewed
Feb 4, 2026
Per reviewer feedback on PR #734: 1. Revert timeout from 30s back to 900s (line 299) - Reviewer noted that with wait=False, timeout is not critical - The async nature and wait=False handle the exit speed 2. Revert telemetry_enabled parameter back to True (line 734) - Reviewer noted this is redundant given the early return - If enable_telemetry=False, we return early (line 729) - Line 734 only executes when enable_telemetry=True - Therefore using the parameter here is unnecessary These changes address the reviewer's valid technical concerns while keeping the core fixes intact: - wait=False for non-blocking shutdown (critical for Issue #729) - Early return when enable_telemetry=False (critical for Issue #729) - All Issue #731 fixes (null-safety, __del__, documentation) Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
msrathore-db
force-pushed
the
fix/telemetry-lifecycle-issues-729-731
branch
from
d4f9054 to
471a551
Compare
msrathore-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Issue #729: Connection failures hang CICD jobs for 15+ minutes, cannot be cancelled
Issue #731: Race condition causes AttributeError: 'NoneType' object has no attribute 'request'
Changes
Issue #729 (3 fixes)
- Added parameter to connection_failure_log() with early return if disabled
- Connection passes user's preference through
- Changed from 900s to 30s for faster failure
- Changed executor.shutdown(wait=True) to wait=False
Issue #731 (3 fixes)
- Check if pool_manager is None before calling .request()
- Raise RequestError with clear message
- Close _http_client during garbage collection
- Ensures eventual resource cleanup
- Added docstring explaining why _http_client isn't closed in close()
- Import RequestError from databricks.sql.exc
Impact
Backward Compatibility
Fully backward compatible. No API changes, only behavior improvements.
Closes #729
Closes #731
How is this tested?
Related Tickets & Documents