Support custom folder in CLI uninstall#1066
Open
moomindani wants to merge 1 commit intodatabrickslabs:mainfrom
Open
Support custom folder in CLI uninstall#1066moomindani wants to merge 1 commit intodatabrickslabs:mainfrom
moomindani wants to merge 1 commit intodatabrickslabs:mainfrom
Conversation
moomindani
requested review from
pratikk-databricks
and removed request for
a team
|
All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
The CLI uninstall script only worked for default installation folders. Users who installed DQX to a custom workspace path could not uninstall via CLI. This adds install_folder support to InstallationService.current() and prompts for the custom path in uninstall.py, mirroring the install flow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
moomindani
force-pushed
the
feature/uninstall-custom-folder-599
branch
from
b32aa24 to
2ff3bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_folderparameter toInstallationService.current()so it can locate installations in custom workspace foldersuninstall.pyto prompt for custom folder path, mirroring the install flowInstallationServicewith custom install folderResolves #599
Test plan
make test— 785 passed)make lint)🤖 Generated with Claude Code