Skip to content

Conversation

@bmagyarkuti
Copy link
Contributor

@bmagyarkuti bmagyarkuti commented Jul 29, 2024

Resolves #1593. Modify build config to support building on arm Mac, Linux environments.

Introduced support by upgrading the rules_nodejs package and its dependencies, and by extending platform-specific build scripts to download the appropriate executables.
Tested by locally executing the scripts/run, scripts/run_tests scripts (needed to use own GCP project and own encrypted key). I also applied this change on top of the 3.0.0 tag and checked that the built cli, core packages contain identical files to those published on NPM. Tested that build works on an Intel and an ARM Linux box (WSL), as well as an Apple Silicon Mac.

Overview of changes:

There are likely parts of the build system that I couldn't test. For example, I don't have access to the CI pipeline.

@bmagyarkuti
Copy link
Contributor Author

I'd like to nominate @Ekrekr as reviewer, as he seems to have done a lot of work around the build system.

@Ekrekr
Copy link
Contributor

Ekrekr commented Jul 30, 2024

Thanks for doing this! I had struggled to get this to work before when experimenting with #1462.

Have run the tests manually and they pass, so I will merge this.

@Ekrekr Ekrekr enabled auto-merge (squash) July 30, 2024 09:14
@Ekrekr Ekrekr disabled auto-merge July 30, 2024 09:15
@Ekrekr Ekrekr merged commit 2469634 into dataform-co:main Jul 30, 2024
@bmagyarkuti bmagyarkuti deleted the arm_compatibility_pr branch July 30, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bazel fails to build the project on Apple silicon processors

2 participants